Re: [libvirt PATCH v8 2/3] Allow VF vlanid to be passed as a pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/1/22 09:28, Dmitrii Shcherbakov wrote:
> There should be a way to show no intent in programming a VLAN at all
> (including clearing it). This allows handling error conditions
> differently when VLAN clearing is explicit (vlan id == 0) vs implicit
> (vlanid == NULL - try to clear it if possible).
> 
> Signed-off-by: Dmitrii Shcherbakov <dmitrii.shcherbakov@xxxxxxxxxxxxx>
> ---
>  src/hypervisor/virhostdev.c |  4 +++-
>  src/util/virnetdev.c        | 41 ++++++++++++++++++++++++-------------
>  src/util/virnetdevpriv.h    |  4 ++--
>  tests/virnetdevtest.c       | 27 ++++++++++++++++++++----
>  4 files changed, 55 insertions(+), 21 deletions(-)

This patch looks okay, but I had to adapt it to meet changes I made to 1/3.

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux