On Mon, Jan 31, 2022 at 03:55:03PM +0100, Pavel Hrdina wrote: > On Mon, Jan 31, 2022 at 03:45:18PM +0100, Michal Prívozník wrote: > > On 1/31/22 15:38, Daniel P. Berrangé wrote: > > > > > > > > Oh, I hadn't checked how number prioritization affects it. So you're > > > saying that we stop parsing the firmware file as soon as we find a > > > valid match. That does indeed limit the impact of the change. > > > > Ah, my memory is failing me. We don't do that. Sorry for the noise. But > > changing the code to do that should be easy enough. > > I was just checking that but we do parse all files. > > Anyway I was wondering that we could modify the code to make the > `nvram-template` mandatory base on the firmware mode or if there is no > firmware mode specified. > > That way we would keep the current behavior for old firmware descriptors > where no firmware mode exists and with the new mode we could do the > right thing. Unless I'm missing someting. Yes, that's what i'll aim todo to address this specific enhancement, but its just another special case fix. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
