Re: [PATCH v2 0/3] Fix hotplug of unassigned hostdevs

[Daniel Henrique Barboza <danielhb413@xxxxxxxxx>]

On 1/26/22 06:29, Michal Privoznik wrote:
> v2 of:
>
> https://listman.redhat.com/archives/libvir-list/2022-January/msg01111.html
>
> Patches 1/3 and 2/3 were ACKed but I'm sending them for completeness.


Back when I've added this UNASSIGNED address type I was also pursuing a PCI multifunction
hotplug/unplug feature in Libvirt and, apparently, I didn't mind testing hotplug/unplug
of non-multifunction unassigned hostdevs like the bug mentioned in patch 1 did.


Thanks for fixing this up.


Daniel

> diff to v1:
> - Reworked patch 3/3
>
> Michal Prívozník (3):
>    domain_validate: Refuse VIR_DOMAIN_DEVICE_ADDRESS_TYPE_UNASSIGNED
>    qemuDomainAttachHostPCIDevice: Handle hostevs with unassigned type of
>      address
>    qemuDomainDetachDeviceLive: Handle hostevs with unassigned type of
>      address
>
>   src/conf/domain_validate.c | 45 ++++++++++++++++++++++++++++++++++++++
>   src/qemu/qemu_hotplug.c    | 11 ++++++++++
>   2 files changed, 56 insertions(+)