Re: [PATCH 2/2] docs: Mention the types of params in event callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 19, 2022 at 12:19:36PM +0800, Han Han wrote:
> Signed-off-by: Han Han <hhan@xxxxxxxxxx>
> ---
>  include/libvirt/libvirt-domain.h  | 14 +++++++-------
>  include/libvirt/libvirt-secret.h  |  2 +-
>  include/libvirt/libvirt-storage.h |  2 +-
>  3 files changed, 9 insertions(+), 9 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

> +++ b/include/libvirt/libvirt-secret.h
> @@ -191,7 +191,7 @@ typedef enum {
>   * @conn: connection object
>   * @secret: secret on which the event occurred
>   * @event: The specific virSecretEventLifecycleType which occurred
> - * @detail: contains some details on the reason of the event.
> + * @detail: contains some details on the reason of the event. It will be 0 for the while.
[...]
> +++ b/include/libvirt/libvirt-storage.h
> @@ -489,7 +489,7 @@ typedef enum {
>   * @conn: connection object
>   * @pool: pool on which the event occurred
>   * @event: The specific virStoragePoolEventLifecycleType which occurred
> - * @detail: contains some details on the reason of the event.
> + * @detail: contains some details on the reason of the event. It will be 0 for the while.

These last two look out of place. I'll change them to

  (Currently unused)

before pushing.

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux