On Thu, Jan 20, 2022 at 10:52:12AM -0300, Daniel Henrique Barboza wrote:
> The PowerNV machine does not implement any form of migration.
What do you mean by that ?
Migration is a general feature in QEMU, not typically something
that a machine types opts in/out of.
It is possible for devices to register migration blockers to
prevent it, but libvirt shouldn't try to second guess that.
Overall I'd like to see a clear justification for why libvirt
should enforce a policy here, as opposed to letting QEMU
accept or reject the migration.
>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx>
> ---
> src/qemu/qemu_migration.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index 2635ef1162..dc2fe92e9b 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -1332,6 +1332,12 @@ qemuMigrationSrcIsAllowed(virQEMUDriver *driver,
> int pauseReason;
> size_t i;
>
> + if (qemuDomainIsPowerNV(vm->def)) {
> + virReportError(VIR_ERR_OPERATION_INVALID, "%s",
> + _("Powernv domains are not migratable"));
> + return false;
> + }
> +
> /* perform these checks only when migrating to remote hosts */
> if (remote) {
> nsnapshots = virDomainSnapshotObjListNum(vm->snapshots, NULL, 0);
> --
> 2.34.1
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
