Re: [libvirt PATCH 4/7] qemu: remove sharedDevices hash table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 13, 2022 at 06:47:39PM +0100, Ján Tomko wrote:
> @@ -649,7 +643,6 @@ qemuDomainChangeEjectableMedia(virQEMUDriver *driver,
>
>      /* remove the old source from shared device list */
>      disk->src = oldsrc;
> -    ignore_value(qemuRemoveSharedDisk(driver, disk, vm->def->name));
>      ignore_value(qemuDomainStorageSourceChainAccessRevoke(driver, vm, oldsrc));

I believe you should also drop the comment, the line where disk->src
is set to oldsrc as well as the one a little bit below where it's set
back to newsrc.

-- 
Andrea Bolognani / Red Hat / Virtualization





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux