Re: [PATCH] virDomainDeviceInfoParseXML: Reject '0' value for ACPI index

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/18/22 15:51, Peter Krempa wrote:
> Value of '0' is treated equivalently to when it's not provided by the
> user. Reject an explicit '0' provided by the user as it would get
> ignored.
> 
> In this rare case we can make the XML parser more strict, as libvirt
> would never format the '<acpi/>' element if the index is '0' thus there
> are no libvirt-generated XMLs we'd not load back, as of such this is
> identical to rejecting it in the validation phase.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2037146
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  src/conf/domain_conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux