On 1/14/22 18:01, Andrea Bolognani wrote: > On Wed, Jan 12, 2022 at 09:47:57AM +0100, Michal Privoznik wrote: >> The function is no longer used. Remove it. >> >> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> >> --- >> src/libvirt_private.syms | 1 - >> src/util/virdnsmasq.c | 14 -------------- >> src/util/virdnsmasq.h | 1 - >> 3 files changed, 16 deletions(-) > > Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> > > Further cleanup opportunities: > > * drop the 'force' argument of dnsmasqCapsRefreshInternal(), as the > only caller always passes true; > > * drop the 'noRefresh' field of the dnsmasqCaps struct, which > AFAICT doesn't really do anything even before your changes; > > * rework dnsmasqCapsSetFromBuffer() so that it takes the output of > the two calls to dnsmasq as separate arguments, instead of doing > the silly dance of joining the two in the caller only to have the > function split them again immediately. > My reasoning to not do all of this was that one day we might want to query capabilities. In which case we might need force/noRefresh. But since we removed the caps enum I guess your suggestion makes more sense. Will fix in v3. Michal
