Re: [libvirt PATCH 00/14] Random fixes and improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2022-01-12 at 15:36 +0100, Michal Prívozník wrote:
> On 1/12/22 14:10, Tim Wiederhake wrote:
> > A collection of drive-by fixes and improvements that quickly
> > derailed
> > into the g_auto-ification of src/conf/interface_conf.c.
> > 
> > Tim Wiederhake (14):
> >   docs: coding-style: Clarify on virXXXPtr types
> >   virQEMUCapsSEVInfoCopy: Remove superfluous g_auto usage
> >   virInterfaceDefDevFormat: Add missing error handling
> >   conf: interface: Preparation for g_auto
> >   conf: interface: Use g_auto
> >   conf: interface: Remove ret and goto
> >   virInterfaceDefParseXML: Inline trivial virInterfaceDefParseName
> >   virInterfaceDefParseIP: Simplify and cleanup
> >   virInterfaceDefParseDhcp: Simplify and cleanup
> >   virInterfaceDefParseProtoIPv4: Simplify and cleanup
> >   virInterfaceDefParseProtoIPv6: Simplify and cleanup
> >   virInterfaceDefParseIfAdressing: Simplify and cleanup
> >   virInterfaceDefParseXML: Simplify and cleanup
> >   virInterfaceDefParse: Simplify and cleanup
> > 
> >  docs/coding-style.rst        |   5 +
> >  src/conf/interface_conf.c    | 357 ++++++++++++-------------------
> > ----
> >  src/qemu/qemu_capabilities.c |   4 +-
> >  3 files changed, 128 insertions(+), 238 deletions(-)
> > 
> 
> Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> 
> Michal
> 
Thanks! I will drop patches 1 and 2 from the series for now: I want to
rewrite #2 entirely and have additional changes for #1.

Tim




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux