On Tue, Jan 11, 2022 at 10:21:32AM +0100, Olaf Hering wrote: > Mon, 3 Jan 2022 03:18:11 -0800 Andrea Bolognani <abologna@xxxxxxxxxx>: > > > The fact that we still QEMU_AUDIO_DRV and SDL_AUDIODRIVER in the > > service file even after your changes goes against this principle. > > So what should be done about these? > > I think whoever added support for these environment variables a couple > of decades ago failed to provide proper documentation. Or perhaps > whoever wrote the "sound" section of formatdomain.html.in failed to > recognize the existence of these environment variables. Dan, do you think it would be okay to simply drop these from the service/sysconfig file? IIUC we have a proper way to set them on a per-domain level now. -- Andrea Bolognani / Red Hat / Virtualization
