Re: [PATCH 1/3] virdnsmasq: Drop @binaryPath argument from dnsmasqCapsNewEmpty()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 10, 2022 at 04:44:53PM +0100, Michal Privoznik wrote:
> Both callers of dnsmasqCapsNewEmpty() pass DNSMASQ as an argument
> which is then fed to a ternary operator which looks like this
> (after substitution).
>
>   DNSMASQ ? DNSMASQ : DNSMASQ
>
> While I like tautologies, the code can be simplified by dropping
> the argument.
>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/util/virdnsmasq.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux