On Mon, Jan 10, 2022 at 01:02:43PM +0000, Andrea Bolognani wrote: > On Mon, Jan 10, 2022 at 01:29:54PM +0100, Olaf Hering wrote: > > Mon, 13 Dec 2021 14:44:51 +0100 Andrea Bolognani <abologna@xxxxxxxxxx>: > > > +``virt-ssh-helper`` is an internal tool > > > > If it is indeed an internal tool, why is the man page in section 1, and why is it in PATH? > > I think the man page needs to be moved to section 8, the binary into $libexec. > > The path to it will be known, the shell code from virNetClientSSHHelperCommand could be removed. > > The path to the helper cannot be hardcoded, and it needs to be in > $PATH, because the shell snippet is generated on the client side but > executed on the server side. The two could have been configured with > different prefixes, as is going to be the case for example when a > macOS client connects to a Linux server. About the section. You might be right that 8 is a better fit than 1, but sections are somewhat loosely defined and I can't quite make up my mind about it. I'm definitely open to moving it if you can make a convincing enough case for it :) -- Andrea Bolognani / Red Hat / Virtualization
