On 1/7/22 09:55, Andrea Bolognani wrote:
On Wed, Jan 05, 2022 at 12:13:28PM -0700, Jim Fehlig wrote:
On 1/3/22 03:49, Olaf Hering wrote:
style issues in docs/ and libvirt.spec.in (abologna)
Hi Andrea,
Thanks for reviewing v6! It looks like Olaf has addressed all of your
comments. Any additional issues with this version?
The concerns mentioned here have not been addressed:
https://listman.redhat.com/archives/libvir-list/2022-January/msg00021.html
I looked at that thread again and want to verify what is missing. IIUC, you
agreed the '--listen' comment is not needed in the service file since it is well
documented in the manpage, etc.
WRT libvirt-guests, Olaf added the comments for each env setting to the top of
the script. I guess what is missing is your request for a comment in the service
file telling where to look? I.e. the following part?
[Service]
# To learn what configuration knobs are available for this
# service, check out the top of the libvirt-guest.sh script
...
Regards,
Jim
