Re: [PATCH 03/21] qemuxml2argvtest: Remove redundant floppy controller tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Thursday in 2022, Peter Krempa wrote:
The two test cases were added to avoid regressions such as fixed in
17dff3584855e9. Nowadays the code is much simpler and any Q35 machine
will trigger the explicit FDC.

Remove the '2.11' machine type version and turn the '2.9' version into a
generic q35 machine.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
tests/qemusecuritytest.c                      |  3 +-
.../disk-floppy-q35-2_11.x86_64-latest.args   | 42 -------------------
.../qemuxml2argvdata/disk-floppy-q35-2_11.xml | 38 -----------------
.../disk-floppy-q35-2_9.x86_64-2.12.0.args    | 36 ----------------
...rgs => disk-floppy-q35.x86_64-2.12.0.args} |  2 +-
...rgs => disk-floppy-q35.x86_64-latest.args} |  2 +-
...floppy-q35-2_9.xml => disk-floppy-q35.xml} |  2 +-
tests/qemuxml2argvtest.c                      |  6 +--
8 files changed, 6 insertions(+), 125 deletions(-)
delete mode 100644 tests/qemuxml2argvdata/disk-floppy-q35-2_11.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-floppy-q35-2_11.xml
delete mode 100644 tests/qemuxml2argvdata/disk-floppy-q35-2_9.x86_64-2.12.0.args
rename tests/qemuxml2argvdata/{disk-floppy-q35-2_11.x86_64-2.12.0.args => disk-floppy-q35.x86_64-2.12.0.args} (96%)
rename tests/qemuxml2argvdata/{disk-floppy-q35-2_9.x86_64-latest.args => disk-floppy-q35.x86_64-latest.args} (96%)
rename tests/qemuxml2argvdata/{disk-floppy-q35-2_9.xml => disk-floppy-q35.xml} (95%)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux