On 12/10/21 21:34, Praveen K Paladugu wrote: > From: Vineeth Pillai <viremana@xxxxxxxxxxxxxxxxxxx> > > Add domainGetVcpuPinInfo and nodeGetCPUMap callbacks to ch driver > > Signed-off-by: Vineeth Pillai <viremana@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Praveen K Paladugu <prapal@xxxxxxxxxxxxxxxxxxx> > --- > src/ch/ch_domain.h | 10 +++++++-- > src/ch/ch_driver.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 59 insertions(+), 2 deletions(-) > > diff --git a/src/ch/ch_domain.h b/src/ch/ch_domain.h > index 1ec7643216..c36405808b 100644 > --- a/src/ch/ch_domain.h > +++ b/src/ch/ch_domain.h > @@ -23,6 +23,7 @@ > #include "ch_conf.h" > #include "ch_monitor.h" > #include "virchrdev.h" > +#include "vircgroup.h" > > /* Give up waiting for mutex after 30 seconds */ > #define CH_JOB_WAIT_TIME (1000ull * 30) > @@ -52,9 +53,14 @@ typedef struct _virCHDomainObjPrivate virCHDomainObjPrivate; > struct _virCHDomainObjPrivate { > struct virCHDomainJobObj job; > > + virChrdevs *chrdevs; > + virCgroup *cgroup; > + virCHDriver *driver; > virCHMonitor *monitor; > - > - virChrdevs *chrdevs; > + char *machineName; > + virBitmap *autoNodeset; > + virBitmap *autoCpuset; > + virChrdevs *devs; Some of these members are not used in this patch. It would be better if they were introduced in the same patch that needs them. Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Michal