On 12/10/21 21:34, Praveen K Paladugu wrote: > Refactor some cgroup management methods from qemu into hypervisor. > These methods will be shared with ch driver for cgroup management. > > Signed-off-by: Praveen K Paladugu <prapal@xxxxxxxxxxxxxxxxxxx> > --- > src/hypervisor/domain_cgroup.c | 426 ++++++++++++++++++++++++++++++++- > src/hypervisor/domain_cgroup.h | 52 ++++ > src/libvirt_private.syms | 13 + > src/qemu/qemu_cgroup.c | 410 +------------------------------ > src/qemu/qemu_cgroup.h | 11 - > src/qemu/qemu_driver.c | 14 +- > src/qemu/qemu_hotplug.c | 7 +- > src/qemu/qemu_process.c | 20 +- > 8 files changed, 522 insertions(+), 431 deletions(-) > > diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms > index 56adc192cd..09b1fbb8c4 100644 > --- a/src/libvirt_private.syms > +++ b/src/libvirt_private.syms > @@ -1543,10 +1543,23 @@ virSetConnectStorage; > > > # hypervisor/domain_cgroup.h > +virCgroupEmulatorAllNodesAllow; > +virCgroupEmulatorAllNodesRestore; > +virConnectCgroup; > virDomainCgroupSetMemoryLimitParameters; > virDomainCgroupSetupBlkio; > virDomainCgroupSetupDomainBlkioParameters; > virDomainCgroupSetupMemtune; > +virInitCgroup; > +virRemoveCgroup; > +virSetupBlkioCgroup; > +virSetupCgroup; > +virSetupCgroupCpusetCpus; > +virSetupCgroupVcpuBW; > +virSetupCpuCgroup; > +virSetupCpusetCgroup; > +virSetupGlobalCpuCgroup; > +virSetupMemoryCgroup; Almost. Notice how pre-exisitng APIs have "virDomainCgroup" prefix? Those function you are moving should have that too. This is where I'm stopping my review. Let me merge patches I've already acked and look forward to v4. Michal
