Re: [PATCH] qemu: agent: remove all code around disabled DEBUG_IO/DEBUG_RAW_IO definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, 6 Jan 2022, Peter Krempa wrote:

> On Tue, Jan 04, 2022 at 17:47:43 +0530, Ani Sinha wrote:
> > DEBUG_IO and DEBUG_RAW_IO are disabled and hence the code #defined under them
> > are useless. Remove them. Also remove similar useless code from
> > qemu_monitor_json.
> >
> > See also 4aae00bf1287f ("qemu: monitor: Remove disabled debug infrastructure")
>
> ~/libvirt $ git show 4aae00bf1287f
> fatal: ambiguous argument '4aae00bf1287f': unknown revision or path not in the working tree.
>
> Which is expected as I didn't yet push the commit you are refering to.

Right but I had applied your commit to my tree and I think the hash would
be the same. I just assumed you would push your commit first and then push
mine and adjust the hash appropriately (if needed at all).

> I'll drop it along with the last sentence of the previous paragraph
> before pushing.
>
> >
> > Signed-off-by: Ani Sinha <ani@xxxxxxxxxxx>
> > ---
> >  src/qemu/qemu_agent.c        | 51 ------------------------------------
> >  src/qemu/qemu_monitor_json.c |  4 ---
> >  2 files changed, 55 deletions(-)
>
> Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
>
>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux