On 12/20/21 19:45, Andrea Bolognani wrote: > On Fri, Dec 10, 2021 at 03:07:10AM -0800, Andrea Bolognani wrote: >> On Fri, Dec 10, 2021 at 11:41:29AM +0100, Peter Krempa wrote: >>>> docs/event_loop_simple.png | Bin 0 -> 16043 bytes >>>> docs/event_loop_simple.svg | 398 +++++++++++++++++ >>>> docs/event_loop_worker.png | Bin 0 -> 29696 bytes >>>> docs/event_loop_worker.svg | 708 +++++++++++++++++++++++++++++++ >>> >>> Shouldn't these files ... >>> >>>> docs/internals/eventloop.html.in | 4 +- >>> >>> .. be inside the 'internals' directory? >> >> For that to work, I'd have to replicate the docs_assets machinery >> found in docs/meson.build to docs/internals/meson.build. >> >> I'm not absolutely against it, and we already have a copy in >> docs/logos/meson.build after all, but using relative paths seemed >> preferable. > > Any further thoughts? I'd like to get this merged, be it in one shape > or another :) > I'd say it's okay. It's just a bunch of pictures. Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Michal
