On 12/17/21 16:20, Boris Fiuczynski wrote: > Commit 93e9e92c1e eliminated the option for skipping but left code in > the s390 check which makes use of a skip. This leads to an output > without result destroying the correct format. e.g. > > QEMU: Checking for hardware virtualization : PASS > QEMU: Checking if device /dev/kvm exists : PASS > QEMU: Checking if device /dev/kvm is accessible : PASS > QEMU: Checking if device /dev/vhost-net exists : PASS > QEMU: Checking if device /dev/net/tun exists : PASS > QEMU: Checking for cgroup 'cpu' controller support : PASS > QEMU: Checking for cgroup 'cpuacct' controller support : PASS > QEMU: Checking for cgroup 'cpuset' controller support : PASS > QEMU: Checking for cgroup 'memory' controller support : PASS > QEMU: Checking for cgroup 'devices' controller support : PASS > QEMU: Checking for cgroup 'blkio' controller support : PASS > QEMU: Checking for device assignment IOMMU support : QEMU: Checking for secure guest support : PASS > > Signed-off-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxx> > --- > tools/virt-host-validate-common.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> and pushed. Michal