On 12/11/21 14:23, Martin Kletzander wrote: > My idea was that running pkttyagent unconditionally, modulo checks that > pkttyagent itself does to make sure it does not fail, is not going to be an > issue turned out to be wrong. Adding back the original check for stdin being a > tty helps in some testing scenarios as reported by Jim Fehlig and does not > really cause any issues. I originally wanted it in because it also made > pkttyagent auth work with redirected input into virsh (with a connection that > requires polkit authentication and without a session-wide polkit tty agent, > basically making pkttyagent necessary to succeed). But anyone running virsh > like that is asking for problems already anyway =) > > Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx> > --- > src/util/virpolkit.c | 3 +++ > 1 file changed, 3 insertions(+) In case you want to push this: Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> But I'd really like to get to the bottom of this. Why does sleep() suspends for that long and why isn't polkit-agent killed? Michal
