Re: [PATCH v2 1/6] manpages: Document 'restrictive' mode for numatune

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for your explanation.  There is another update for the man page in patch 4/6 and that's the final version after the whole patch. I missed that.

BR,
Jing Qi

On Fri, Dec 17, 2021 at 3:54 PM Michal Prívozník <mprivozn@xxxxxxxxxx> wrote:
On 12/17/21 02:35, Jing Qi wrote:
> Hi Michal,
> Seems there is a typo of 'restrictive' instead of 'strict'  in the last
> line of updated content. Right?

Actually, no. What this patch does is document the current state of
things. With current master, 'restrictive' is not allowed and only
'strict' is (the fact it doesn't work really is addressed in later
patches in this series). Therefore, I think this patch is correct as is.

But I see where you're coming from. In the end there will be only
'restrictive' allowed.

The reason I chose to do things separately is for easier cherry pick /
revert. Imagine at some point in future we will be able to tell QEMU to
migrate its own memory. Then we might want to revert patch 4/6 which
will leave us with:

 For a running domain, the mode can't be changed, and the nodeset can be
 changed only if the domain was started with mode of either \`strict' or
 \`restrictive'.


Hopefully, my explanation makes sense.

Michal



--
Thanks & Regards,
Jing,Qi

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux