Re: [libvirt PATCH v2 05/12] tools: add 'domlaunchsecinfo' virsh command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 10, 2021 at 11:37:28 +0000, Daniel P. Berrangé wrote:
> This command reports the launch security parameters for
> a guest, allowing an external tool to perform a launch
> attestation.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  docs/manpages/virsh.rst | 17 +++++++++++++
>  tools/virsh-domain.c    | 53 +++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 70 insertions(+)
> 
> diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
> index 275f416090..1a74217625 100644
> --- a/docs/manpages/virsh.rst
> +++ b/docs/manpages/virsh.rst
> @@ -2057,6 +2057,23 @@ destination hosts have synchronized time (i.e., NTP daemon is running
>  on both of them).
>  
>  
> +domlaunchsecinfo
> +----------------
> +
> +**Syntax:**
> +
> +::
> +
> +   domlaunchsecinfo domain
> +
> +Returns information about the launch security parameters associated
> +with a running domain.
> +
> +The set of parameters reported will vary depending on which type of
> +launch security protection is active. If none is active, no parameters
> +will be reported.

Too bad that https://www.libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetLaunchSecurityInfo
doesn't link to all the fields it returns because in case of commands
such as this one it would be beneficial to at least link to the API docs
outlining what the values are.

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux