> > > Almost identical XML parsing code for either strings or files was copied > > > 15 times. Since it was needed on two other places for parsing CPU XML > > > strings with correct error reporting, I decided to factor the parsing code > > > out to xml.c and used this one implementation in all other places. > > > > looking very quickly, this looks sensible, but I can't fully review > > this right now, ACK on principle though, maybe this can wait for 0.7.8. > > Okay, reread them, looks just fine by me, ACK, let's push them > once 0.7.7 is out :-) As 0.7.7 has been out for some time now, I pushed these patches. Actually, they were very close to being forgotten forever :-) Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list