> -----Original Message----- > From: Richard Henderson [mailto:richard.henderson@xxxxxxxxxx] > Sent: Sunday, November 21, 2021 6:35 AM > To: Jiangyifei <jiangyifei@xxxxxxxxxx>; qemu-devel@xxxxxxxxxx; > qemu-riscv@xxxxxxxxxx > Cc: bin.meng@xxxxxxxxxxxxx; limingwang (A) <limingwang@xxxxxxxxxx>; > kvm@xxxxxxxxxxxxxxx; libvir-list@xxxxxxxxxx; anup.patel@xxxxxxx; wanbo (G) > <wanbo13@xxxxxxxxxx>; Alistair.Francis@xxxxxxx; > kvm-riscv@xxxxxxxxxxxxxxxxxxx; Wanghaibin (D) > <wanghaibin.wang@xxxxxxxxxx>; palmer@xxxxxxxxxxx; Fanliang (EulerOS) > <fanliang@xxxxxxxxxx>; Wubin (H) <wu.wubin@xxxxxxxxxx> > Subject: Re: [PATCH v1 12/12] target/riscv: Support virtual time context > synchronization > > On 11/20/21 8:46 AM, Yifei Jiang wrote: > > const VMStateDescription vmstate_riscv_cpu = { > > .name = "cpu", > > .version_id = 3, > > .minimum_version_id = 3, > > + .post_load = cpu_post_load, > > .fields = (VMStateField[]) { > > VMSTATE_UINTTL_ARRAY(env.gpr, RISCVCPU, 32), > > VMSTATE_UINT64_ARRAY(env.fpr, RISCVCPU, 32), @@ -211,6 > > +221,10 @@ const VMStateDescription vmstate_riscv_cpu = { > > VMSTATE_UINT64(env.mtohost, RISCVCPU), > > VMSTATE_UINT64(env.timecmp, RISCVCPU), > > > > + VMSTATE_UINT64(env.kvm_timer_time, RISCVCPU), > > + VMSTATE_UINT64(env.kvm_timer_compare, RISCVCPU), > > + VMSTATE_UINT64(env.kvm_timer_state, RISCVCPU), > > + > > VMSTATE_END_OF_LIST() > > }, > > Can't alter VMStateDescription.fields without bumping version. > > If this is really kvm-only state, consider placing it into a subsection. But I > worry about kvm-only state because ideally we'd be able to migrate between > tcg and kvm (if only for debugging). > > > r~ Thanks, I will update the version in the next series and place it into a subsection. Yifei
