Re: [PATCH V2 0/3] Add virDomainSetLaunchSecurityState API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 09, 2021 at 15:04:12 -0700, Jim Fehlig wrote:
> V2 of https://listman.redhat.com/archives/libvir-list/2021-November/msg00980.html
> 
> Like V1, this series is compile-tested only. I plan to work on functional
> testing soon, after wrapping up some tasks.

I have 2 minor comments:

- virsh impl is missing and it's not justified why
- 'qemuMonitorJSONSetLaunchSecurityState' is missing a test case in
  qemumonitorjsontest. A simple test with GEN_TEST_FUNC/DO_TEST_GEN is
  enough, it validates the arguments against the QMP monitor schema.




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux