On Thu, Dec 09, 2021 at 16:24:04 +0000, Daniel P. Berrangé wrote: > On Thu, Dec 09, 2021 at 09:36:03AM +0100, Peter Krempa wrote: > > On Wed, Dec 08, 2021 at 18:44:31 +0000, Daniel P. Berrangé wrote: > > > We're only returning the set of fields needed to perform an > > > attestation, per the SEV API docs. > > > > > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > > > --- > > > src/qemu/qemu_monitor.c | 13 +++++++++++ > > > src/qemu/qemu_monitor.h | 9 ++++++++ > > > src/qemu/qemu_monitor_json.c | 45 ++++++++++++++++++++++++++++++++++++ > > > src/qemu/qemu_monitor_json.h | 8 +++++++ > > > 4 files changed, 75 insertions(+) [...] > > > diff --git a/src/qemu/qemu_monitor_json.h b/src/qemu/qemu_monitor_json.h > > > index 0984717675..163be25c32 100644 > > > --- a/src/qemu/qemu_monitor_json.h > > > +++ b/src/qemu/qemu_monitor_json.h > > > @@ -369,6 +369,14 @@ int qemuMonitorJSONSystemWakeup(qemuMonitor *mon); > > > > > > char *qemuMonitorJSONGetSEVMeasurement(qemuMonitor *mon); > > > > > > +int qemuMonitorJSONGetSEVInfo(qemuMonitor *mon, > > > + unsigned int *apiMajor, > > > + unsigned int *apiMinor, > > > + unsigned int *buildID, > > > + unsigned int *policy) > > > + ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3) > > > + ATTRIBUTE_NONNULL(4) ATTRIBUTE_NONNULL(5); > > > > Preferrably use modern header formatting. > > Almost everything in this header uses the style matching > this patch. IMHO divering in style is worse. Fair enough: https://listman.redhat.com/archives/libvir-list/2021-December/msg00362.html
