On Mon, Mar 22, 2010 at 02:28:51PM -0600, Eric Blake wrote: > On 03/22/2010 01:05 PM, Daniel P. Berrange wrote: > > + if (virDomainUpdateDeviceFlags (dom, args->xml, args->flags) == -1) { > > + virDomainFree(dom); > > Inconsistency in whether there is a space before ( in function calls. > Which style is intended, or are both permitted? This was a copy & paste mistake. Functions should not have any spaces between their name & (, though plenty of code violates this Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list