Re: [libvirt PATCH] meson: Improve network driver enablement logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Friday in 2021, Andrea Bolognani wrote:
The Homebrew package explicitly enables this driver despite us
disabling it by default on macOS, so it must be functional to
at least some extent and certainly can't be causing any build
failures.

Additionally, if the user has explicitly asked for the network
driver to be enabled but libvirtd is disabled for whatever
reason, we should error out instead of silently disabling the
network driver.

Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
---
Homebrew formula showing that the network driver is
explicitly enabled in the package:
https://github.com/Homebrew/homebrew-core/blob/3aff61292a3ed16bc715ba23fc2fa74251d82aa4/Formula/libvirt.rb#L58

Test pipeline showing that enabling the network driver by
default on macOS doesn't result in build failures:
https://gitlab.com/abologna/libvirt/-/pipelines/421956249

meson.build | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux