On Fri, 2021-11-26 at 16:44 +0100, Martin Kletzander wrote: > On Wed, Nov 10, 2021 at 10:24:27PM +0800, Luke Yue wrote: > > Currently it will only be used in test driver. > > > > Signed-off-by: Luke Yue <lukedyue@xxxxxxxxx> > > --- > > src/conf/domain_conf.c | 24 ++++++++++++++++++++++++ > > src/conf/domain_conf.h | 4 ++++ > > src/libvirt_private.syms | 1 + > > 3 files changed, 29 insertions(+) > > > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > > index 512bfab9e9..92a8bd63f3 100644 > > --- a/src/conf/domain_conf.c > > +++ b/src/conf/domain_conf.c > > @@ -16998,6 +16998,30 @@ virDomainTPMDefRemove(virDomainDef *def, > > } > > > > > > +bool > > +virDomainMemballoonDefEquals(const virDomainMemballoonDef *a, > > + const virDomainMemballoonDef *b) > > It is really weird that you picked the membaloon as that particular > one > does not really make sense to be present multiple times, it is > similar > to the watchdog device. It is not a problem in this case, but I feel > like this function is a bit useless. Oh, sorry, I didn't realize that, I forgot that the device would just present once, so that we can just remove the device without comparison, I will remove the comparison function. Thanks, Luke
