Re: [libvirt PATCH 03/11] qemu_snapshot: create: move disk align to separate function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Thursday in 2021, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
---
src/qemu/qemu_snapshot.c | 115 ++++++++++++++++++++++-----------------
1 file changed, 65 insertions(+), 50 deletions(-)

diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index 5ebe959151..7198a2aad3 100644
--- a/src/qemu/qemu_snapshot.c
+++ b/src/qemu/qemu_snapshot.c
@@ -1631,6 +1631,69 @@ qemuSnapshotCreateXMLValidateDef(virDomainObj *vm,
}


+static int
+qemuSnapshotAlignDisks(virDomainObj *vm,
+                       virDomainSnapshotDef *def,
+                       virQEMUDriver *driver,
+                       unsigned int flags)

All the other functions you separated from qemuSnapshotCreateXML
use the qemuSnapshotCreate prefix.

I think it makes sense here too, since 'flags' are
VIR_DOMAIN_SNAPSHOT_CREATE* flags.

Jano

+{
+    g_autofree char *xml = NULL;
+    qemuDomainObjPrivate *priv = vm->privateData;
+    int align_location = VIR_DOMAIN_SNAPSHOT_LOCATION_INTERNAL;
+    bool align_match = true;
+

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux