Re: [PATCH 1/1] bash-completion: fix variable leaks of "IFS" and "word"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/14/21 07:06, Koichi Murase wrote:
> ---
>  tools/bash-completion/vsh.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/bash-completion/vsh.in b/tools/bash-completion/vsh.in
> index 70ade50a02..4399ff0a64 100644
> --- a/tools/bash-completion/vsh.in
> +++ b/tools/bash-completion/vsh.in
> @@ -4,7 +4,7 @@
>  
>  _@command@_complete()
>  {
> -    local words cword c=0 i=0 cur RO URI CMDLINE INPUT A
> +    local words cword c=0 i=0 cur word RO URI CMDLINE INPUT A

The word variable is also used only inside a while loop (not visible in
the context). So it can be declared local there instead of here. I'll
fix that before pushing.

However, we do require developers to provide signoff for their patches
to signal their compliance with DCO:

https://libvirt.org/hacking.html#developer-certificate-of-origin

No need to resend the whole patch, it's sufficient if you reply with
your SoB line.

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux