On Mon, Nov 22, 2021 at 04:38:42PM +0100, Ján Tomko wrote:
On a Sunday in 2021, Martin Kletzander wrote:With this function we can decide whether to try running the polkit text agent only if it is available, removing a potential needless error saying that the agent binary does not exist, which is useful especially when running the agent before knowing whether it is going to be needed. Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx> --- src/libvirt_private.syms | 1 + src/util/virpolkit.c | 44 ++++++++++++++++++++++++++++++++++++++++ src/util/virpolkit.h | 1 + 3 files changed, 46 insertions(+)Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>
I changed the virFileExists to virFileIsExecutable as mentioned in the thread for patch 7/7, so I'll amend it here. Hope that's fine, if not then take it as a trivial change ;)
Jano
Attachment:
signature.asc
Description: PGP signature