On Mon, Mar 22, 2010 at 04:43:25PM +0000, Daniel P. Berrange wrote: > On Mon, Mar 22, 2010 at 05:37:02PM +0100, Daniel Veillard wrote: > > On Fri, Mar 19, 2010 at 03:38:59PM +0000, Daniel P. Berrange wrote: > > > +typedef enum { > > > + VIR_DOMAIN_EVENT_WATCHDOG_NONE = 0, > > > + VIR_DOMAIN_EVENT_WATCHDOG_PAUSE, > > > + VIR_DOMAIN_EVENT_WATCHDOG_RESET, > > > + VIR_DOMAIN_EVENT_WATCHDOG_POWEROFF, > > > + VIR_DOMAIN_EVENT_WATCHDOG_SHUTDOWN, > > > + VIR_DOMAIN_EVENT_WATCHDOG_DEBUG, > > > +} virDomainEventWatchdogAction; > > > > Hum, what is NONE for ? Sounds more confusing than anything else to me. > > Also a short description would be useful, for example is the watchdog > > pause an user requested pause ? And what does the debug carries ? > > NONE means that QEMU just ignores the watchdog, even when it triggers > > DEBUG means that QEMU ignores it, but logs a message on stderr (which > ends up in /var/log/libvirt/qemu/$GUEST.log in our case) > > PAUSE means that QEMU stops the guest CPUs when the watchdog fires. Ah okay, I was thinking PAUSE meant the watchdog had been paused momentarily (but there was no restart !) We really need the semantic to be explained in the header :) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list