Re: [libvirt PATCH] qemu_command: do not use host-nodes for system memory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/9/21 3:13 PM, Pavel Hrdina wrote:
> Commit 88957116c9d3cb4705380c3702c9d4315fb500bb switched to use
> memory-backend-* for regular VM memory as well. That change indirectly
> started using 'host-nodes' for system memory which results in QEMU
> calling mbind() to bind the system memory to specific NUMA node if the
> VM XML contains the configuration similar to this:
> 
>   ...
>   <numatune>
>     <memory mode='strict' nodeset='0'/>
>   </numatune>
>   ...
> 
> Once the VM was started with that configuration it was no longer
> possible to change the memory NUMA nodeset.
> 
> Fixes: 677c90cc1d1fcb3aba09b5d4f0f8f83099911775
> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> ---
>  src/qemu/qemu_command.c                       |  3 +-
>  .../numatune-system-memory.x86_64-latest.args | 32 +++++++++++++++++++
>  .../numatune-system-memory.xml                | 24 ++++++++++++++
>  tests/qemuxml2argvtest.c                      |  1 +
>  4 files changed, 59 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemuxml2argvdata/numatune-system-memory.x86_64-latest.args
>  create mode 100644 tests/qemuxml2argvdata/numatune-system-memory.xml

Oops, yes.

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux