On Mon, Nov 8, 2021 at 6:49 AM Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> wrote: > > On 11/8/21 10:24, Daniel P. Berrangé wrote: > > On Mon, Nov 08, 2021 at 08:59:51AM +0100, Thomas Huth wrote: > >> On 05/11/2021 16.53, Willian Rampazzo wrote: > >>> This introduces a new `make` target, `check-avocado`, and adds a > >>> deprecation message about the `check-acceptance` target. This is > >>> a preparation for renaming the `tests/acceptance` folder to > >>> `tests/avocado`. > >>> > >>> The plan is to remove the call to the `check-avocado` target one > >>> or two months after the release and leave the warning to force > >>> people to move to the new `check-avocado` target. > >>> > >>> Later, the `check-acceptance` target can be removed. The intent > >>> is to avoid a direct impact during the current soft freeze. > >>> > >>> Suggested-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> > >>> Signed-off-by: Willian Rampazzo <willianr@xxxxxxxxxx> > >>> --- > >>> docs/about/deprecated.rst | 13 +++++++++++++ > >>> tests/Makefile.include | 17 ++++++++++++----- > >>> 2 files changed, 25 insertions(+), 5 deletions(-) > >>> > >>> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst > >>> index 56f9ad15ab..7bf8da8325 100644 > >>> --- a/docs/about/deprecated.rst > >>> +++ b/docs/about/deprecated.rst > >>> @@ -410,3 +410,16 @@ nanoMIPS ISA > >>> The ``nanoMIPS`` ISA has never been upstreamed to any compiler toolchain. > >>> As it is hard to generate binaries for it, declare it deprecated. > >>> + > >>> +Testing > >>> +------- > >>> + > >>> +Renaming of the acceptance folder to avocado > >>> +'''''''''''''''''''''''''''''''''''''''''''' > >>> + > >>> +The ``tests/acceptance`` folder was never used to store acceptance tests > >>> +in terms of software engineering. This naming can confuse developers > >>> +adding tests using the Avocado Framework to this folder. The folder > >>> +name change to ``tests/avocado`` also changed the ``make`` target from > >>> +``check-acceptance`` to ``check-avocado``. In this case, the use of the > >>> +``check-acceptance`` target is deprecated. > >> > >> Not sure whether we need to document this in deprecated.rst, too, since > >> we're normally only listing the things here that affect the users of the > >> qemu binaries, not the people who want to recompile and run the tests... > >> OTOH, I don't mind too much either if we list it here... Anybody else got an > >> opinion on this? > > > > Deprecations are only things for user facing changes in the apps. > > OK. > > > For build system changes we don't bother with any deprecation cycle. > > Just make the change immediately and document it in the release notes. > > Understood. > > Willian, do you mind updating the release notes? > https://wiki.qemu.org/ChangeLog/6.2#Testing_and_CI > Sure, I can do that, but I think I need to wait for the patch to be merged, right?
