Tim already acked v1, but I noticed a failure in the CI in patch 5/7 because with the latest caps, we try to create a logfile for one chardev in /tmp. Fix that by only testing name-escape with v2.11.0 QEMU caps. I've heard rumors of Peter having a patch ready that would make qemuxml2argv testing possible with all kinds of chardev, so the latest version of the tests can possibly be added later. Ján Tomko (7): tests: remove disks from spice tests tests: qemuxml2xmltest: move graphics-spice-timeout tests: qemuxml2xml: use latest caps for spice tests tests: qemuxml2argv: use latest caps for spice tests tests: convert name-escape to use real caps qemu: always assume QEMU_CAPS_SPICE_UNIX qemu: retire QEMU_CAPS_SPICE_UNIX src/qemu/qemu_capabilities.c | 3 +- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_validate.c | 10 +-- .../caps_2.11.0.x86_64.xml | 1 - .../caps_2.12.0.x86_64.xml | 1 - .../caps_3.0.0.x86_64.xml | 1 - .../caps_3.1.0.x86_64.xml | 1 - .../caps_4.0.0.riscv32.xml | 1 - .../caps_4.0.0.riscv64.xml | 1 - .../caps_4.0.0.x86_64.xml | 1 - .../caps_4.1.0.x86_64.xml | 1 - .../caps_4.2.0.x86_64.xml | 1 - .../caps_5.0.0.riscv64.xml | 1 - .../caps_5.0.0.x86_64.xml | 1 - .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 - .../caps_5.1.0.x86_64.xml | 1 - .../caps_5.2.0.riscv64.xml | 1 - .../caps_5.2.0.x86_64.xml | 1 - .../caps_6.0.0.x86_64.xml | 1 - .../caps_6.1.0.x86_64.xml | 1 - .../caps_6.2.0.aarch64.xml | 1 - .../caps_6.2.0.x86_64.xml | 1 - .../graphics-spice-agent-file-xfer.args | 34 --------- ...s-spice-agent-file-xfer.x86_64-latest.args | 35 +++++++++ .../graphics-spice-agent-file-xfer.xml | 5 -- .../graphics-spice-agentmouse.args | 36 --------- ...aphics-spice-agentmouse.x86_64-latest.args | 37 +++++++++ .../graphics-spice-agentmouse.xml | 5 -- ...-spice-auto-socket-cfg.x86_64-latest.args} | 17 +++-- ...hics-spice-auto-socket.x86_64-latest.args} | 17 +++-- .../graphics-spice-compression.args | 34 --------- ...phics-spice-compression.x86_64-latest.args | 35 +++++++++ .../graphics-spice-compression.xml | 5 -- .../graphics-spice-egl-headless.args | 34 --------- ...hics-spice-egl-headless.x86_64-latest.args | 35 +++++++++ .../graphics-spice-egl-headless.xml | 5 -- .../graphics-spice-invalid-egl-headless.xml | 5 -- .../graphics-spice-no-args.args | 31 -------- .../graphics-spice-no-args.x86_64-latest.args | 34 +++++++++ .../graphics-spice-qxl-vga.args | 34 --------- .../graphics-spice-qxl-vga.x86_64-latest.args | 35 +++++++++ .../graphics-spice-qxl-vga.xml | 5 -- .../qemuxml2argvdata/graphics-spice-sasl.args | 34 --------- .../graphics-spice-sasl.x86_64-latest.args | 35 +++++++++ .../qemuxml2argvdata/graphics-spice-sasl.xml | 6 -- .../graphics-spice-socket.args | 30 -------- .../graphics-spice-socket.x86_64-latest.args | 33 ++++++++ .../graphics-spice-timeout.args | 40 ---------- .../graphics-spice-timeout.x86_64-latest.args | 38 ++++++++++ .../graphics-spice-timeout.xml | 13 ---- .../graphics-spice-usb-redir.args | 38 ---------- ...raphics-spice-usb-redir.x86_64-latest.args | 41 ++++++++++ tests/qemuxml2argvdata/graphics-spice.args | 34 --------- .../graphics-spice.x86_64-latest.args | 35 +++++++++ tests/qemuxml2argvdata/graphics-spice.xml | 5 -- ...pe.args => name-escape.x86_64-2.11.0.args} | 7 +- tests/qemuxml2argvtest.c | 75 ++++--------------- ...s-spice-auto-socket-cfg.x86_64-latest.xml} | 5 +- ...phics-spice-auto-socket.x86_64-latest.xml} | 5 +- ...phics-spice-compression.x86_64-latest.xml} | 11 +-- ...hics-spice-egl-headless.x86_64-latest.xml} | 11 +-- ... graphics-spice-qxl-vga.x86_64-latest.xml} | 11 +-- ...> graphics-spice-socket.x86_64-latest.xml} | 5 +- ... graphics-spice-timeout.x86_64-latest.xml} | 15 +--- ...e.xml => graphics-spice.x86_64-latest.xml} | 11 +-- tests/qemuxml2xmltest.c | 35 ++------- 66 files changed, 471 insertions(+), 614 deletions(-) delete mode 100644 tests/qemuxml2argvdata/graphics-spice-agent-file-xfer.args create mode 100644 tests/qemuxml2argvdata/graphics-spice-agent-file-xfer.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/graphics-spice-agentmouse.args create mode 100644 tests/qemuxml2argvdata/graphics-spice-agentmouse.x86_64-latest.args rename tests/qemuxml2argvdata/{graphics-spice-auto-socket-cfg.args => graphics-spice-auto-socket-cfg.x86_64-latest.args} (50%) rename tests/qemuxml2argvdata/{graphics-spice-auto-socket.args => graphics-spice-auto-socket.x86_64-latest.args} (50%) delete mode 100644 tests/qemuxml2argvdata/graphics-spice-compression.args create mode 100644 tests/qemuxml2argvdata/graphics-spice-compression.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/graphics-spice-egl-headless.args create mode 100644 tests/qemuxml2argvdata/graphics-spice-egl-headless.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/graphics-spice-no-args.args create mode 100644 tests/qemuxml2argvdata/graphics-spice-no-args.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/graphics-spice-qxl-vga.args create mode 100644 tests/qemuxml2argvdata/graphics-spice-qxl-vga.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/graphics-spice-sasl.args create mode 100644 tests/qemuxml2argvdata/graphics-spice-sasl.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/graphics-spice-socket.args create mode 100644 tests/qemuxml2argvdata/graphics-spice-socket.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/graphics-spice-timeout.args create mode 100644 tests/qemuxml2argvdata/graphics-spice-timeout.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/graphics-spice-usb-redir.args create mode 100644 tests/qemuxml2argvdata/graphics-spice-usb-redir.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/graphics-spice.args create mode 100644 tests/qemuxml2argvdata/graphics-spice.x86_64-latest.args rename tests/qemuxml2argvdata/{name-escape.args => name-escape.x86_64-2.11.0.args} (90%) rename tests/qemuxml2xmloutdata/{graphics-spice-auto-socket-cfg.xml => graphics-spice-auto-socket-cfg.x86_64-latest.xml} (88%) rename tests/qemuxml2xmloutdata/{graphics-spice-auto-socket.xml => graphics-spice-auto-socket.x86_64-latest.xml} (88%) rename tests/qemuxml2xmloutdata/{graphics-spice-compression.xml => graphics-spice-compression.x86_64-latest.xml} (86%) rename tests/qemuxml2xmloutdata/{graphics-spice-egl-headless.xml => graphics-spice-egl-headless.x86_64-latest.xml} (83%) rename tests/qemuxml2xmloutdata/{graphics-spice-qxl-vga.xml => graphics-spice-qxl-vga.x86_64-latest.xml} (85%) rename tests/qemuxml2xmloutdata/{graphics-spice-socket.xml => graphics-spice-socket.x86_64-latest.xml} (88%) rename tests/qemuxml2xmloutdata/{graphics-spice-timeout.xml => graphics-spice-timeout.x86_64-latest.xml} (82%) rename tests/qemuxml2xmloutdata/{graphics-spice.xml => graphics-spice.x86_64-latest.xml} (87%) -- 2.31.1