Re: [PATCH] virsh: Fix ambiguous output in metadata-change event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/27/21 10:52 AM, Han Han wrote:
> When you set metadata with type element like the following:
> dom.setMetadata(libvirt.VIR_DOMAIN_METADATA_ELEMENT, "<test/>", 'abc', "HAHAH", 0)
> 
> Then for `virsh event --all`, then it will output this message:
> event 'metadata-change' for domain 'rhel9': element HAHAH
> 
> The message is ambiguous since it looks like the params for
> metadata-change event is the element HAHAH. Actually that means the type is
> element while the url is HAHAH. Let's make it more clear.
> 
> Signed-off-by: Han Han <hhan@xxxxxxxxxx>
> ---
>  tools/virsh-domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux