On Thu, Mar 18, 2010 at 08:12:47PM +0100, Jiri Denemark wrote:
> ---
> src/qemu/qemu_driver.c | 70 +++++++++++++++++++++++++++++++++++++++++-
> src/qemu/qemu_monitor.c | 15 +++++++++
> src/qemu/qemu_monitor.h | 3 ++
> src/qemu/qemu_monitor_json.c | 29 +++++++++++++++++
> src/qemu/qemu_monitor_json.h | 3 ++
> src/qemu/qemu_monitor_text.c | 27 ++++++++++++++++
> src/qemu/qemu_monitor_text.h | 3 ++
> 7 files changed, 149 insertions(+), 1 deletions(-)
May comment about time scale for virsh CLI just raised a question here
in the QEmu driver:
[...]
> +int qemuMonitorJSONSetMigrationDowntime(qemuMonitorPtr mon,
> + unsigned long long downtime)
> +{
> + int ret;
> + char *downtimestr;
> + virJSONValuePtr cmd;
> + virJSONValuePtr reply = NULL;
> + if (virAsprintf(&downtimestr, "%llun", downtime) < 0) {
Hum, just wondering, QEmu interface really takes nanoseconds as its
input or shouldn't that be scaled down ? And in case we forgot to scale
down, we need to be very careful if the division leads to 0, assuming
migrate_set_downtime 0
may mean something completely different from what we asked .
Can you confirm QEmu uses nanoseconds input ?
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list