Re: [PATCH 090/103] qemuBuildControllersByTypeCommandLine: Generate via JSON

[Ján Tomko <jtomko@xxxxxxxxxx>]

On a Thursday in 2021, Peter Krempa wrote:
> The handlers for PCI, SCSI and USB controllers already use JSON
> internally. This patch converts 'virtio-serial', 'ccid' and 'sata' to do
> the same and passes out the JSON directly so that it can be used in
> monitor code to avoid conversion.
>
> > From the controllers converted in this patch only 'virtio-serial' has
> special properties. QEMU thinks they have the following types:
>
>  max_ports=<uint32>     -  (default: 31)
>  vectors=<uint32>       -  (default: 2)
>
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
> src/qemu/qemu_command.c | 122 +++++++++++++++-------------------------
> src/qemu/qemu_command.h |   9 +--
> src/qemu/qemu_hotplug.c |   8 +--
> 3 files changed, 54 insertions(+), 85 deletions(-)

Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature