On Mon, Oct 11, 2021 at 09:04:43AM +0200, Peter Krempa wrote: > On Fri, Oct 08, 2021 at 18:51:54 +0200, Andrea Bolognani wrote: > > case VIR_DOMAIN_IOMMU_MODEL_VIRTIO: > > + if (qemuBuildVirtioDevStr(&opts, "virtio-iommu", qemuCaps, > > + VIR_DOMAIN_DEVICE_IOMMU, iommu) < 0) { > > + return -1; > > + } > > + > > + if (qemuBuildDeviceAddressStr(&opts, def, &iommu->info) < 0) > > + return -1; > > Note that both function won't exist after I push my series refactoring > -device generation. You'll need to use the *Props versions. Thanks for the heads up! I'll keep an eye out for your series being merged and send out a rebased version once that happens :) -- Andrea Bolognani / Red Hat / Virtualization