On Wed, Oct 06, 2021 at 10:27:48 +0200, Ján Tomko wrote: > On a Wednesday in 2021, Peter Krempa wrote: > > On Wed, Oct 06, 2021 at 09:15:16 +0200, Ján Tomko wrote: > > > Iterate through the array to find the first free index. > > > > > > Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx> > > > --- > > > src/qemu/qemu_alias.c | 18 ++++++++++++++---- > > > 1 file changed, 14 insertions(+), 4 deletions(-) [...] > > > @@ -634,7 +644,7 @@ qemuAssignDeviceAliases(virDomainDef *def, virQEMUCaps *qemuCaps) > > > } > > > > > > for (i = 0; i < def->nfss; i++) { > > > - if (qemuAssignDeviceFSAlias(def->fss[i], i) < 0) > > > + if (qemuAssignDeviceFSAlias(def, def->fss[i]) < 0) > > > return -1; > > > > Are other devices also n^2 during startup of the VM? > > > > For the alias assingment, many of the hotpluggable ones are. Sigh. Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>