Re: [libvirt PATCH v5 5/7] Add PCI VPD Capability Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>
> It's probably irrelevant since this will be mostly rewritten based on
> Dan's suggestions, but the resFormatFunc() pointer seems like an
> unnecessary complication - you could just move the if/else construct
> down to here and call the appropriate function directly.
>

Ack, I was trying to reuse the same parent type and a function
signature to handle resource formatting in a generic way - in case new
resource types ever got added.

But that was probably too forward-looking.




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux