On Fri, Sep 24, 2021 at 11:04:20AM +0200, Kevin Wolf wrote: > The only thing the string visitor adds compared to a keyval visitor is > list support. git grep for 'visit_start_list' and 'visit.*List' shows > that devices don't make use of this. > > In a world with a QAPIfied command line interface, the keyval visitor is > used to parse the command line. In order to make sure that no devices > start using this feature that would make backwards compatibility harder, > just switch away from object_property_parse(), which internally uses the > string visitor, to a keyval visitor and object_property_set(). > > Signed-off-by: Kevin Wolf <kwolf@xxxxxxxxxx> > --- > softmmu/qdev-monitor.c | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake <eblake@xxxxxxxxxx> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org