Re: [PATCH 1/5] virsh: checkpoint & domain-monitor: small refactoring

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 23, 2021 at 17:08:00 +0200, Kristina Hanicova wrote:
> This patch includes small refactoring such as:
> * early return in case of an error - helps with indentation
> * removal of 'else' branch after return - unnecessary
> * altering code to be more consistent with the rest of the file -
>   function calls inside of parentheses, etc.
> * removal of unnecessary variables - mainly the ones used for
>   return value instead of returning it directly
> * missing parentheses around multi-line block of code

There's a bit too much going on in this patch. It definitely goes
against the guidance to make patches small, self contained and easy to
review.




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux