Re: [libvirt PATCH 0/9] ch: use g_auto where possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/22/21 4:55 PM, Ján Tomko wrote:
While cleaning up the tests, I noticed that the 'ch' driver is
not using g_auto up to its full potential.

Use automatic cleanup where possible and remove redundant labels.

Ján Tomko (9):
   ch: use g_auto in virCHMonitorBuildCPUJson
   ch: use g_auto in virCHMonitorBuildKernelRelatedJson
   ch: use g_auto in virCHMonitorBuildMemoryJson
   ch: use g_auto in virCHMonitorBuildDiskJson
   ch: use g_auto in virCHMonitorBuildDisksJson
   ch: use g_auto in virCHMonitorBuildNetJson
   ch: use g_auto in virCHMonitorBuildNetsJson
   ch: use g_auto in virCHMonitorBuildVMJson
   ch: use g_auto in virCHMonitorNew

  src/ch/ch_monitor.c | 167 +++++++++++++++++---------------------------
  1 file changed, 63 insertions(+), 104 deletions(-)


I pointed out pre-existing object leaks in patch 2 & 9, which you could just fix with simple prerequisite patches. Aside from that

Reviewed-by: Laine Stump <laine@xxxxxxxxxx>

for the series.




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux