On Fri, Sep 17, 2021 at 11:19:46AM +0200, Peter Krempa wrote: > On Fri, Sep 17, 2021 at 09:27:15 +0100, Daniel P. Berrangé wrote: > > On Thu, Sep 16, 2021 at 07:10:31PM +0200, Peter Krempa wrote: > > > When inspecting whether https://gitlab.com/libvirt/libvirt/-/issues/9 is > > > still valid I wrote a tool which outputs command options missing > > > completers. Now that I had a bit of time with lot of interruptions which > > > is ideal for going through such a thing I decided to clean up > > > the tool and post it along with a few fixes and additions to completers. > > > > This series seems to have broken the build for most layered project > > CI pipelines > > Could you link to them? https://libvirt.org/ci.html > > ../tools/vsh.c: In function ‘vshCompleteHelpCommand’: > > ../tools/vsh.c:3035:12: error: implicit declaration of function ‘vshReadlineCommandGenerator’ [-Werror=implicit-function-declaration] > > return vshReadlineCommandGenerator(); > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > ../tools/vsh.c:3035:12: error: nested extern declaration of ‘vshReadlineCommandGenerator’ [-Werror=nested-externs] > > ../tools/vsh.c:3035:12: error: returning ‘int’ from a function with return type ‘char **’ makes pointer from integer without a cast [-Werror=int-conversion] > > return vshReadlineCommandGenerator(); > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Looks like they build without 'readline'. All of libvirt's jobs use > readline btw. > > I've fixed it in the meanwhile, but for a more stable CI layered > products should use the same set of deps we use in our CI. They all use a minimal set of dependancies to cut down on the build time, as they ideally only want the libvirt.so library and nothing else. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
