Sorry I did not notify to this e-mail thread, I resent patches following there 3 reviews on Sep/09 03:35 UTC. I'm glad if you could review it.
-----Original Message-----
From: Peter Krempa <pkrempa@xxxxxxxxxx>
Sent: Wednesday, September 8, 2021 8:33 PM
To: 成川 弘樹 <hnarukaw@xxxxxxxxxxxxx>
Cc: libvir-list@xxxxxxxxxx; 大岩 朗 <aoiwa@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] qemu: add virtio-blk queue-size option
On Mon, Sep 06, 2021 at 17:06:15 +0900, Hiroki Narukawa wrote:
Same as previous patches.
> ---
> src/qemu/qemu_command.c | 3 ++
> src/qemu/qemu_validate.c | 6 ++++
> .../disk-virtio-queue-size.args | 29 +++++++++++++++
> .../disk-virtio-queue-size.xml | 35 +++++++++++++++++++
> tests/qemuxml2argvtest.c | 2 ++
> .../disk-virtio-queue-size.xml | 35 +++++++++++++++++++
> tests/qemuxml2xmltest.c | 1 +
> 7 files changed, 111 insertions(+)
> create mode 100644 tests/qemuxml2argvdata/disk-virtio-queue-size.args
> create mode 100644 tests/qemuxml2argvdata/disk-virtio-queue-size.xml
> create mode 100644
> tests/qemuxml2xmloutdata/disk-virtio-queue-size.xml
[...]
> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index
> 3b331d5fd4..43532c3890 100644
> --- a/tests/qemuxml2argvtest.c
> +++ b/tests/qemuxml2argvtest.c
> @@ -1341,6 +1341,8 @@ mymain(void)
> DO_TEST("disk-order", QEMU_CAPS_VIRTIO_BLK_SCSI);
> DO_TEST("disk-virtio-queues",
> QEMU_CAPS_VIRTIO_BLK_NUM_QUEUES);
> + DO_TEST("disk-virtio-queue-size",
> + QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE);
All new test cases should use DO_TEST_CAPS_LATEST instead of fake capabilities.
If you are striving to match what is done for the 'queues' you should convert that case first to DO_TEST_CAPS_LATEST (in a separate commit).
> DO_TEST_NOCAPS("disk-boot-disk");
> DO_TEST_NOCAPS("disk-boot-cdrom");
> DO_TEST_NOCAPS("floppy-drive-fat");
[...]
> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index
> 6d3526f91f..ee1ee88b85 100644
> --- a/tests/qemuxml2xmltest.c
> +++ b/tests/qemuxml2xmltest.c
> @@ -302,6 +302,7 @@ mymain(void)
> DO_TEST_NOCAPS("disk-virtio");
> DO_TEST_NOCAPS("floppy-drive-fat");
> DO_TEST("disk-virtio-queues", QEMU_CAPS_VIRTIO_BLK_NUM_QUEUES);
> + DO_TEST("disk-virtio-queue-size",
> + QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE);
Here too.
> DO_TEST_NOCAPS("disk-boot-disk");
> DO_TEST_NOCAPS("disk-boot-cdrom");
> DO_TEST_NOCAPS("disk-error-policy");
> --
> 2.17.1
>
