On Mon, Sep 06, 2021 at 17:06:13 +0900, Hiroki Narukawa wrote: Missing commit message. Please describe what and why you are adding. You also need provide certification that your patches are in compliance with the Developer Certificate of Origin: https://www.libvirt.org/hacking.html#developer-certificate-of-origin > --- > docs/schemas/domaincommon.rng | 5 +++++ > src/conf/domain_conf.c | 6 ++++++ > src/conf/domain_conf.h | 1 + > 3 files changed, 12 insertions(+) Additionally this is also missing documentation for the XML format (docs/formatdomain.rst). [...] > diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h > index c7e6df7981..688a842660 100644 > --- a/src/conf/domain_conf.h > +++ b/src/conf/domain_conf.h > @@ -584,6 +584,7 @@ struct _virDomainDiskDef { > virDomainDiskDetectZeroes detect_zeroes; > char *domain_name; /* backend domain name */ > unsigned int queues; > + unsigned int queue_size; This (along also with 'queues') feels like a guest-OS visible property and thus must be covered by the ABI stability check [1] unless there are good technical reasons why not. 'queues' is not currently is not covered, so for bonus points you can fix that one too (in a separate commit). [1] See virDomainDiskDefCheckABIStability
