Re: [libvirt PATCH 20/24] tests: libxl: remove pointless labels

[Laine Stump <laine@xxxxxxxxxx>]

On 9/4/21 4:44 PM, Ján Tomko wrote:

> diff --git a/tests/xmconfigtest.c b/tests/xmconfigtest.c
> index bd23e5fd5d..c99d1f2bd9 100644
> --- a/tests/xmconfigtest.c
> +++ b/tests/xmconfigtest.c
> @@ -41,7 +41,6 @@ testCompareParseXML(const char *xmcfg, const char *xml)
>   {
>       g_autofree char *gotxmcfgData = NULL;
>       g_autoptr(virConf) conf = NULL;
> -    int ret = -1;
>       g_autoptr(virConnect) conn = NULL;
>       int wrote = 4096;
>       g_autoptr(virDomainDef) def = NULL;
> @@ -49,32 +48,29 @@ testCompareParseXML(const char *xmcfg, const char *xml)
>       gotxmcfgData = g_new0(char, wrote);
>   
>       conn = virGetConnect();
> -    if (!conn) goto fail;

What is (was) this? perl?? :-P

> +    if (!conn)
> +        return -1;