On Tue, Aug 31, 2021 at 12:16:13 +0100, Daniel P. Berrangé wrote: > On Tue, Aug 31, 2021 at 12:03:06PM +0200, Ján Tomko wrote: > > As of qemu commit: > > > > commit 497a30dbb065937d67f6c43af6dd78492e1d6f6d > > qemu-img: Require -F with -b backing image > > > > creating images with backing images requires specifying the format. > > > > Remove tests which do not pass the backing format on the command > > line. > > > > Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx> > > --- > > tests/virstoragetest.c | 33 --------------------------------- > > 1 file changed, 33 deletions(-) > > This fixes the broken 'make check' on Fedora rawhide with QEMU 6.1.0 > > Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Since I don't have time to come up with a proper fix for the release, please push this as-is for now and I'll revert it later. The cases being removed are important for testing the secure handling of backing images missing format so we'll need to have a stash of images if qemu-img can't create them any more. Note that I think the qemu patch forbidding format-less images is unfortunate because fixing them is not always secure and this can lead to users automating it in an insecure way.
